Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in ufloat_fromstr doctring examples #286

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

Cs137
Copy link
Contributor

@Cs137 Cs137 commented Jan 18, 2025

@Cs137 Cs137 changed the title Fix typos in ufloat_fromstr doctring examples (#285) Fix typos in ufloat_fromstr doctring examples (#285) Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (bcff480) to head (2d64785).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files          17       17           
  Lines        1947     1947           
=======================================
  Hits         1880     1880           
  Misses         67       67           
Flag Coverage Δ
macos-latest-3.10 95.01% <ø> (ø)
macos-latest-3.11 95.01% <ø> (ø)
macos-latest-3.12 95.01% <ø> (ø)
macos-latest-3.8 95.01% <ø> (ø)
macos-latest-3.9 95.01% <ø> (ø)
no-numpy 75.14% <ø> (ø)
ubuntu-latest-3.10 95.01% <ø> (ø)
ubuntu-latest-3.11 95.01% <ø> (ø)
ubuntu-latest-3.12 95.01% <ø> (ø)
ubuntu-latest-3.8 95.01% <ø> (ø)
ubuntu-latest-3.9 95.01% <ø> (ø)
windows-latest-3.10 95.01% <ø> (ø)
windows-latest-3.11 95.01% <ø> (ø)
windows-latest-3.12 95.01% <ø> (ø)
windows-latest-3.8 95.01% <ø> (ø)
windows-latest-3.9 95.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 18, 2025

CodSpeed Performance Report

Merging #286 will not alter performance

Comparing Cs137:fix-typos (2d64785) with master (bcff480)

Summary

✅ 5 untouched benchmarks

@Cs137 Cs137 changed the title Fix typos in ufloat_fromstr doctring examples (#285) Fix typos in ufloat_fromstr doctring examples Jan 20, 2025
@Cs137 Cs137 force-pushed the fix-typos branch 2 times, most recently from 9adf108 to b587fc3 Compare January 20, 2025 08:13
@Cs137
Copy link
Contributor Author

Cs137 commented Jan 23, 2025

Would someone be so kind to let me know how to initialise a review of my PR?
The linked documentation and in particular this section is not useful at all, since the mentioned icon is not available to me. The sidebar on the right hand side of the conversation tab shows only the following:

Reviewers
No reviews
Still in progress? Convert to draft

@andrewgsavage andrewgsavage merged commit 1975a4d into lmfit:master Jan 24, 2025
22 checks passed
This was referenced Jan 24, 2025
@Cs137 Cs137 deleted the fix-typos branch January 24, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ufloat_fromstr documentation and parsing Typos in ufloat_fromstr doctring examples
2 participants