Fix stride in test res-in-struct-mix#734
Conversation
| Binding: 6 | ||
| - Name: BufOut | ||
| Kind: RWBuffer | ||
| Kind: RWStructuredBuffer |
There was a problem hiding this comment.
Why this change? This isn't changing the stride.
There was a problem hiding this comment.
Because its another bug in the test see line 20: RWStructuredBuffer<int4> Out : register(u0);
There was a problem hiding this comment.
This should be mentioned in the description, otherwise it looks like an accidental change.
There was a problem hiding this comment.
Actually, this comment doesn't seem to be accurate. There are no resource arrays, only resources, and these are classes, not structs.
farzonl
added
the
test-all
|
@joaosaffran you will need to push another commit or rebase. the test-all tag was placed after the CI started so the AMD gpu machine didn't run your pr. |
farzonl
left a comment
farzonl
left a comment
There was a problem hiding this comment.
Seeing both amd and intel passing now. LGTM!
|
add a fix line for #643 aswell |
6 participants
The stride was wrong for res-in-struct-mix.test, this patches fixes it making it pass in AMD GPUs
Also Fix Out Buffer type from
RWBuffertoRWStructuredBuffer.fixes: #655
fixes #643