Conversation
inbelic
added
the
test-all
inbelic
force-pushed
the
inbelic/loop-peel
branch
3 times, most recently
from
d0c4dbe to
4a30387
Compare
inbelic
force-pushed
the
inbelic/loop-peel
branch
from
725e5e7 to
192aaf4
Compare
inbelic
changed the title
inbelic
removed
the
test-all
bob80905
reviewed
Feb 18, 2026
| - Name: Out | ||
| Format: UInt32 | ||
| Data: [ 0, 0, 0, 0, 0, 0, 0, 0 ] | ||
| Stride: 16 |
Contributor
There was a problem hiding this comment.
I think the stride should be 4, same for expectedout
| # XFAIL: !WARP && Clang && (DirectX || Metal) | ||
| # XFAIL: Vulkan && Darwin | ||
| # Bug https://github.com/llvm/llvm-project/issues/165288 | ||
| # XFAIL: Clang && !Vulkan |
Contributor
There was a problem hiding this comment.
I think you still need Vulkan && Darwin here
Contributor
Author
There was a problem hiding this comment.
IIUC, I don't think this ever happens, we only use the metal shader converter with dxil generated code
bob80905
approved these changes
Feb 18, 2026
spall
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the test case to more directly highlight the underlying issue. Namely that for the NV and QC test failures, it is because there is an unexpected number of active lanes during the invocation of
WaveActiveCountBits(true).This additionally highlights another issue with AMD as it appears to report in quads in an unexpected manner.