Skip to content

Conversation

@TejaX-Alaghari
Copy link

This PR refactors MachineModuleSlotTracker to support both the Legacy Pass Manager and New Pass Manager by removing its direct dependency on MachineModuleInfo.

MachineModuleSlotTracker requires MachineModuleInfo to obtain MachineFunction instances when printing MIR. But MachineFunctionAnalysis provides MachineFunction for NPM.

This patch refactors MachineModuleSlotTracker to use a function callback (MFGetterFnT) instead of directly depending on MachineModuleInfo.

vikramRH and others added 2 commits December 9, 2025 10:18
see "[CodeGen] Avoid MachineModuleInfo in MachineModuleSlotTracker (PR 140530)"
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

- Fix parameter name inconsistency (MFA -> FAM) in header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants