Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/19.x: [Clang][perf-training] Fix clean command in perf-helper.py (#118978) #119051

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

llvmbot
Copy link
Member

@llvmbot llvmbot commented Dec 7, 2024

Backport 18af3fc

Requested by: @tstellar

@llvmbot llvmbot added this to the LLVM 19.X Release milestone Dec 7, 2024
@llvmbot
Copy link
Member Author

llvmbot commented Dec 7, 2024

@petrhosek What do you think about merging this PR to the release branch?

@llvmbot llvmbot requested a review from petrhosek December 7, 2024 02:41
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Dec 7, 2024
@llvmbot
Copy link
Member Author

llvmbot commented Dec 7, 2024

@llvm/pr-subscribers-clang

Author: None (llvmbot)

Changes

Backport 18af3fc

Requested by: @tstellar


Full diff: https://github.com/llvm/llvm-project/pull/119051.diff

1 Files Affected:

  • (modified) clang/utils/perf-training/perf-helper.py (+1-1)
diff --git a/clang/utils/perf-training/perf-helper.py b/clang/utils/perf-training/perf-helper.py
index 3ed42a187fd803..d76c6ede3fe5a2 100644
--- a/clang/utils/perf-training/perf-helper.py
+++ b/clang/utils/perf-training/perf-helper.py
@@ -36,7 +36,7 @@ def clean(args):
             + "\tRemoves all files with extension from <path>."
         )
         return 1
-    for path in args[1:-1]:
+    for path in args[0:-1]:
         for filename in findFilesWithExtension(path, args[-1]):
             os.remove(filename)
     return 0

The first path argument was always being ignored, and since most calls
to this command only passed one path, it wasn't actually doing anything
in most cases.

This bug was introduced by dd0356d.

(cherry picked from commit 18af3fc)
@tru tru merged commit 3d21a9a into llvm:release/19.x Dec 17, 2024
3 of 5 checks passed
Copy link

@tstellar (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

@tru tru deleted the issue118978 branch December 17, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
Development

Successfully merging this pull request may close these issues.

4 participants