Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Fix build metrics container push #118130

Merged

Conversation

boomanaiden154
Copy link
Contributor

This patch fixes a couple typos that were preventing the build metrics container job from pushing the container to GHCR.

This patch fixes a couple typos that were preventing the build metrics
container job from pushing the container to GHCR.
@llvmbot
Copy link
Member

llvmbot commented Nov 29, 2024

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

This patch fixes a couple typos that were preventing the build metrics container job from pushing the container to GHCR.


Full diff: https://github.com/llvm/llvm-project/pull/118130.diff

1 Files Affected:

  • (modified) .github/workflows/build-metrics-container.yml (+2-2)
diff --git a/.github/workflows/build-metrics-container.yml b/.github/workflows/build-metrics-container.yml
index 4f6fb14b21cb6c..751ab679411dcb 100644
--- a/.github/workflows/build-metrics-container.yml
+++ b/.github/workflows/build-metrics-container.yml
@@ -35,7 +35,7 @@ jobs:
         run: |
           tag=`date +%s`
           container_name="ghcr.io/$GITHUB_REPOSITORY_OWNER/metrics"
-          echo "container-name=$container-name" >> $GITHUB_OUTPUT
+          echo "container-name=$container_name" >> $GITHUB_OUTPUT
           echo "container-name-tag=$container_name:$tag" >> $GITHUB_OUTPUT
           echo "container-filename=$(echo $container_name:$tag  | sed -e 's/\//-/g' -e 's/:/-/g').tar" >> $GITHUB_OUTPUT
       - name: Build Container
@@ -71,7 +71,7 @@ jobs:
           name: container
       - name: Push Container
         run: |
-          podman load -i ${{ needs.build-metrics-container.outptus.container-filename }}
+          podman load -i ${{ needs.build-metrics-container.outputs.container-filename }}
           podman tag ${{ needs.build-metrics-container.outputs.container-name-tag }} ${{ needs.build-metrics-container.outputs.container-name }}:latest
           podman login -u ${{ github.actor }} -p $GITHUB_TOKEN ghcr.io
           podman push ${{ needs.build-metrics-container.outputs.container-name-tag }}

@boomanaiden154 boomanaiden154 merged commit 2de2e7a into main Nov 29, 2024
10 checks passed
@boomanaiden154 boomanaiden154 deleted the users/boomanaiden154/fix-metrics-container-upload branch November 29, 2024 20:09
TIFitis pushed a commit to TIFitis/llvm-project that referenced this pull request Dec 18, 2024
This patch fixes a couple typos that were preventing the build metrics
container job from pushing the container to GHCR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants