Skip to content

Commit ae4befe

Browse files
committed
[hlsl] Pin hlsl-test-all resusable workflow to main branch
This will cause each hlsl test workflow to load the hlsl-test-all file from the main branch instead of from the source branch of the PR. PROs: * We can constrain use of the self-hosted Offload Runners to the hlsl-test-all workflow. * This will protect the runners from "Script Kiddie" attacks where someone submits a PR with a malicious workflow to many repositories at once. CONs: * This *will not* protect the Offload Runners from someone submitting a PR that modifies the LLVM source to execute malicious code when built. * It will not be possible to test changes to the hlsl-test-all workflow in a PR. We would need to set up some other process for doing this e.g. a special branch name that can be pushed to to test changes.
1 parent b900379 commit ae4befe

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/hlsl-matrix.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
runs-on:
2424
- hlsl-macos
2525

26-
uses: ./.github/workflows/hlsl-test-all.yaml
26+
uses: llvm/llvm-project/.github/workflows/hlsl-test-all.yaml@main
2727
with:
2828
SKU: hlsl-macos
2929
TestTarget: check-hlsl-clang-mtl # TODO: This target changes based on SKU

0 commit comments

Comments
 (0)