Skip to content

Commit

Permalink
[hlsl] Pin hlsl-test-all resusable workflow to main branch
Browse files Browse the repository at this point in the history
This will cause each hlsl test workflow to load the hlsl-test-all file
from the main branch instead of from the source branch of the PR.

PROs:
 * We can constrain use of the self-hosted Offload Runners to the
   hlsl-test-all workflow.
 * This will protect the runners from "Script Kiddie" attacks where
   someone submits a PR with a malicious workflow to many repositories
   at once.

CONs:
 * This *will not* protect the Offload Runners from someone submitting a
   PR that modifies the LLVM source to execute malicious code when built.
 * It will not be possible to test changes to the hlsl-test-all workflow
   in a PR.  We would need to set up some other process for doing this
   e.g. a special branch name that can be pushed to to test changes.
  • Loading branch information
tstellar committed Jan 10, 2025
1 parent b900379 commit ae4befe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/hlsl-matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
runs-on:
- hlsl-macos

uses: ./.github/workflows/hlsl-test-all.yaml
uses: llvm/llvm-project/.github/workflows/hlsl-test-all.yaml@main
with:
SKU: hlsl-macos
TestTarget: check-hlsl-clang-mtl # TODO: This target changes based on SKU
Expand Down

0 comments on commit ae4befe

Please sign in to comment.