Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Support __builtin___memset_chk #1053

Closed
wants to merge 1 commit into from

Conversation

smeenai
Copy link
Collaborator

@smeenai smeenai commented Nov 4, 2024

This follows the same implementation as CodeGen. #1051 tracks potentially switching to a different strategy in the future.

This follows the same implementation as CodeGen. llvm#1051
tracks potentially switching to a different strategy in the future.
@smeenai
Copy link
Collaborator Author

smeenai commented Nov 4, 2024

(note that I'm doing some manual stacking here, I'll fix that up after #1032 passes CI and I merge it; this shouldn't be merged in the meantime)

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smeenai smeenai deleted the branch llvm:users/smeenai/memcpy-chk November 4, 2024 23:04
@smeenai smeenai closed this Nov 4, 2024
@smeenai
Copy link
Collaborator Author

smeenai commented Nov 4, 2024

Ugh, GitHub doesn't allow you to change the PR base. I'll push manually.

@smeenai smeenai deleted the memset-check branch November 4, 2024 23:08
smeenai added a commit that referenced this pull request Nov 4, 2024
This follows the same implementation as CodeGen. #1051
tracks potentially switching to a different strategy in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants