new config setting - margo.server_address#821
Open
MichaelBrim wants to merge 1 commit intollnl:devfrom
Open
Conversation
Collaborator
Author
|
@CamStan Have you had a chance to figure out why the CI builds are not running? |
Member
@MichaelBrim My apologies for the delay on this. I have the builds mostly working again, but am hitting a compilation error that I've argued myself in a circle on what a fix for this one might be: Builds are here: https://github.com/CamStan/UnifyFS/actions/runs/17686445589 |
Collaborator
Author
|
@CamStan Yes, same issue as reported in #822 . I have a commit in my service-pool branch with my suggested fix, which is to not override the system definition and just use our own custom function (see #822 (comment)) |
Allows users to explicity set the Mercury address to use for server-to-server communication. Useful when there are multiple interfaces that support the ofi+tcp protocol, or to use a different protocol. TEST_CHECKPATCH_SKIP_FILES=common/src/unifyfs_configurator.h,docs/configuration.rst
82f5d41 to
a1bd92a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows users to explicitly set the Mercury address to use for server-to-server communication.
Motivation and Context
Useful when there are multiple interfaces that support the ofi+tcp protocol, or to use a different protocol.
How Has This Been Tested?
Tested in a docker environment using different network interface and protocol.
Types of changes
Checklist: