開発者ごとに Stack が分けられるようにする #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icoxfog417
reviewed
Jan 17, 2024
packages/cdk/lib/construct/llm.ts
Outdated
|
|
||
| constructor(scope: Construct, id: string) { | ||
| super(scope, id); | ||
|
|
||
| // Specify Endpoint with stage suffix | ||
| const stage = this.node.tryGetContext('stage'); | ||
| this.endpointName = `llm-jp-endpoint-${stage}`; |
There was a problem hiding this comment.
prefix にするか suffix にするかは統一したほうが良いと思いました。prefix に統一ですかね?
packages/cdk/lib/construct/llm.ts
Outdated
| @@ -21,11 +21,15 @@ export class LLM extends Construct { | |||
| '-' + new Date().toISOString().replace(/[:T-]/g, '').split('.')[0]; | |||
| public readonly endpointConfigName = | |||
| 'llm-jp-endpoint-config' + this.deploy_suffix; | |||
There was a problem hiding this comment.
endpointConfigName にも ${stage} の付与が必要ですか?
There was a problem hiding this comment.
確かに同時にデプロイするとコンフリクト起こすかもしれないので Prefix 付与します。
maekawataiki
force-pushed
the
issue-38/multiple-stack
branch
from
8b039ac to
57c853f
Compare
icoxfog417
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#38
Description
-c stage=<stage>でデプロイ環境を分けれるように変更