Rewrite chandra_genspcreg.sh with python3 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitianux
requested changes
Oct 15, 2018
bin/make_spcreg.py
Outdated
| parser.add_argument("-s", "--step", dest="step", type=int, default=5, | ||
| help="calculation step (default:5)") | ||
| parser.add_argument("-o", "--outfile", dest="outfile", | ||
| default="spc_reg.reg", |
| parser.add_argument("-H", "--ehigh", dest="ehigh", type=int, default=7000, | ||
| help="upper energy limit [eV] (default: 7000 [eV])") | ||
| parser.add_argument("-s", "--step", dest="step", type=int, default=5, | ||
| help="calculation step (default:5)") |
Owner
There was a problem hiding this comment.
calculation step 没说清楚这个参数是用来做什么的。这个说明写长一点没关系。另外还要说明这个数的单位是什么。
|
|
||
|
|
||
| def genspecreg(evtfile, bkg_spec, outfile, reg_centroid, | ||
| step=5, cnts_min=2500): |
Owner
There was a problem hiding this comment.
- 函数名称改为
gen_regions() - 这个函数太长了，处理的事情太多。我觉得应当拆分成大概 3 个函数。
比如，reg_centroid 应为 center，直接提供中心坐标，而不要在这个函数里去解析区域文件。
| parser.add_argument("-L", "--elow", dest="elow", type=int, default=700, | ||
| help="lower energy limit [eV] (default: 700 [eV])") | ||
| parser.add_argument("-H", "--ehigh", dest="ehigh", type=int, default=7000, | ||
| help="upper energy limit [eV] (default: 7000 [eV])") |
Owner
There was a problem hiding this comment.
增加一个参数 --min-counts 表示每个分区里（扣除背景后）的最少光子数，默认为 2500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.