Prepare Jetpack parser for outputing stylesheet as a map #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NduatiK
commented
Sep 28, 2024
NduatiK
commented
- Remove variable related code since we are using EEx
- Always return a list of modifiers (instead of the inner tuple for singletons)
- Return annotations as a map instead of keyword list
- Remove variable related code since we are using EEx - Always return a list of modifiers (instead of the inner tuple for singletons) - Return annotations as a map instead of keyword list
NduatiK
changed the title
bcardarella
reviewed
Nov 21, 2024
| @@ -18,7 +18,7 @@ defmodule LiveViewNative.Jetpack.RulesParserTest do | |||
| {line, input} = {__ENV__.line, "\nbold(true)"} | |||
|
|
|||
| # We add 1 because the modifier is on the second line of the input | |||
| output = {:bold, [file: __ENV__.file, line: line + 1, module: __ENV__.module, source: "bold(true)"], [true]} | |||
| output = [[:bold, %{file: __ENV__.file, line: line + 1, module: __ENV__.module, source: "bold(true)"}, [true]]] | |||
There was a problem hiding this comment.
the annotations should still be a keyword list, not a map
|
I think this PR is now invalidated by liveview-native/live_view_native_stylesheet#89. It will handle the proper encoding of the AST. The internal representation does't need to change. @NduatiK close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.