ai/live: Support for multiple instances per orchestrator in discovery #3719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es with concurrency and timeout
…text propagation Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
…ction variable Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
…instances Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for orchestrators to advertise additional instances during discovery.
The broadcaster will then query these additional instances
This is done via a new
-instancesflag on the orchestrator, which takes a comma-separated list of HTTPS URLs. The OrchestratorInfo RPC message is modified to take a list of string instances.Additionally, support a special zero value of "none" for the
-serviceAddrflag which marks this node as a "non-working" node. This mode may be helpful when a node is only meant to redirect traffic to additional instances, rather than perform work itself.The gateway will recursively call GetOrchestrator on any additional instances it encounters within an OrchestratorInfo response, and will not add responses to its working set that have an empty
Transcoder(serviceAddr) field.For the purposes of selection, latency is calculated directly between the gateway and the additional node itself; the latency to the first node is ignored. However, GetOrchestrator calls to additional nodes are still subject to the overall discovery timeout, which is not extended to accommodate additional nodes. Any additional nodes beyond the first should have a low latency to the gateway.
On the gateway, a new flag
-additionalInstancesis added which limits the number of additional instances the gateway will query. The default is zero, which has the effect of ignoring any additional instances