Skip to content

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Jul 16, 2025

Draft for now as I'm doing a final round of e2e testing locally.

Commits

ai/live: Add delayed teardowns to trickle server.

This allows for reads to a channel after closing, but not writes.

Closed channels are swept after the idle timeout period.

ai/live: Add unit tests for trickle delayed teardowns.
Add a mock for the time.Now function for testing.

ai/live: Const-ify status code 470 to StatusNoSegment

j0sh added 3 commits July 16, 2025 22:37
This allows for reads to a channel after closing, but not writes.

Closed channels are swept after the idle timeout period.
Add a mock for the time.Now function for testing.
@j0sh j0sh requested review from victorges, leszko and mjh1 July 16, 2025 22:41
@github-actions github-actions bot added the go Pull requests that update Go code label Jul 16, 2025
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 31.80072%. Comparing base (dc64e3d) to head (3ec80f6).

Files with missing lines Patch % Lines
trickle/local_publisher.go 0.00000% 9 Missing ⚠️
trickle/trickle_server.go 93.33333% 2 Missing ⚠️
trickle/trickle_subscriber.go 50.00000% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3681         +/-   ##
===================================================
+ Coverage   31.74935%   31.80072%   +0.05137%     
===================================================
  Files            156         156                 
  Lines          47349       47370         +21     
===================================================
+ Hits           15033       15064         +31     
+ Misses         31434       31421         -13     
- Partials         882         885          +3     
Files with missing lines Coverage Δ
trickle/trickle_subscriber.go 71.95122% <50.00000%> (ø)
trickle/trickle_server.go 74.19355% <93.33333%> (+3.92328%) ⬆️
trickle/local_publisher.go 18.36735% <0.00000%> (-2.56288%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc64e3d...3ec80f6. Read the comment docs.

Files with missing lines Coverage Δ
trickle/trickle_subscriber.go 71.95122% <50.00000%> (ø)
trickle/trickle_server.go 74.19355% <93.33333%> (+3.92328%) ⬆️
trickle/local_publisher.go 18.36735% <0.00000%> (-2.56288%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll do the review again and approve when the PR is set to Ready. But in general, all looks good.

Copy link
Contributor

@mjh1 mjh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants