Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-2343] Stream attempts metric #3347

Merged

Conversation

pwilczynskiclearcode
Copy link
Contributor

@pwilczynskiclearcode pwilczynskiclearcode commented Jan 10, 2025

What does this pull request do? Explain your changes. (required)
A new prometheus counter added - ai_live_attempt. The metric counts the number of AI live stream start attempts. The metric is generated early, before any connection to Os.

We could additionally add a runOnConnect mediamtx hook sth like:

MTX_PATHDEFAULTS_RUNONCONNECT: curl "..../live/video-to-video/$MTX_PATH/connect"

receive it on the AI Gateway and log to prometheus from there

Copy link

linear bot commented Jan 10, 2025

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Jan 10, 2025
@pwilczynskiclearcode pwilczynskiclearcode force-pushed the pawel/eng-2343-metrics-add-stream-attempts-metric branch from 35fab19 to 55b0b28 Compare January 10, 2025 13:01
@pwilczynskiclearcode pwilczynskiclearcode force-pushed the pawel/eng-2343-metrics-add-stream-attempts-metric branch from 55b0b28 to 02ef2f1 Compare January 10, 2025 13:12
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.73146%. Comparing base (b026313) to head (9d4f9fe).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_http.go 0.00000% 3 Missing ⚠️
server/ai_process.go 0.00000% 3 Missing ⚠️
monitor/census.go 80.00000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3347         +/-   ##
===================================================
+ Coverage   33.72537%   33.73146%   +0.00609%     
===================================================
  Files            141         141                 
  Lines          37411       37425         +14     
===================================================
+ Hits           12617       12624          +7     
- Misses         24073       24080          +7     
  Partials         721         721                 
Files with missing lines Coverage Δ
monitor/census.go 62.10526% <80.00000%> (+0.11851%) ⬆️
server/ai_http.go 9.98440% <0.00000%> (-0.03125%) ⬇️
server/ai_process.go 0.59778% <0.00000%> (-0.00102%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b026313...9d4f9fe. Read the comment docs.

Files with missing lines Coverage Δ
monitor/census.go 62.10526% <80.00000%> (+0.11851%) ⬆️
server/ai_http.go 9.98440% <0.00000%> (-0.03125%) ⬇️
server/ai_process.go 0.59778% <0.00000%> (-0.00102%) ⬇️

... and 1 file with indirect coverage changes

@pwilczynskiclearcode pwilczynskiclearcode force-pushed the pawel/eng-2343-metrics-add-stream-attempts-metric branch 2 times, most recently from 91135e2 to 8afa4f1 Compare January 10, 2025 14:36
@pwilczynskiclearcode pwilczynskiclearcode force-pushed the pawel/eng-2343-metrics-add-stream-attempts-metric branch from 8afa4f1 to 9d4f9fe Compare January 10, 2025 14:41
@pwilczynskiclearcode pwilczynskiclearcode merged commit 4d09ba7 into master Jan 10, 2025
18 checks passed
@pwilczynskiclearcode pwilczynskiclearcode deleted the pawel/eng-2343-metrics-add-stream-attempts-metric branch January 10, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants