Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover from panic while RunSegmentation #3342

Closed
wants to merge 2 commits into from

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jan 8, 2025

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@leszko leszko marked this pull request as ready for review January 8, 2025 09:09
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 8, 2025
@leszko leszko marked this pull request as draft January 8, 2025 09:13
@leszko leszko marked this pull request as ready for review January 8, 2025 09:28
@leszko leszko marked this pull request as draft January 8, 2025 09:30
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.71481%. Comparing base (17832e7) to head (8818913).

Files with missing lines Patch % Lines
media/rtmp2segment.go 0.00000% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3342         +/-   ##
===================================================
- Coverage   33.72469%   33.71481%   -0.00988%     
===================================================
  Files            141         141                 
  Lines          37391       37399          +8     
===================================================
- Hits           12610       12609          -1     
- Misses         24061       24070          +9     
  Partials         720         720                 
Files with missing lines Coverage Δ
media/rtmp2segment.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17832e7...8818913. Read the comment docs.

Files with missing lines Coverage Δ
media/rtmp2segment.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes

@leszko leszko closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant