ai/live: Fix early EOFs in media reader #3314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes if the reader is slow to pull data (eg, during a retry) and the buffer grows larger than a read then closes, the reader may incorrectly signal EOF and return incomplete data. Don't do that.
The practical consequence here is we would sometime write truncated segments to the server, since the trickle publish is serviced by the segment reader which is being fixed here