Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway/events: Create status API with stream/pipeline ID info #3310

Merged
merged 16 commits into from
Dec 12, 2024

Conversation

gioelecerati
Copy link
Member

What does this pull request do? Explain your changes. (required)

Specific updates (required)
Draft

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes missing coverage. Please review.

Project coverage is 34.00324%. Comparing base (75af747) to head (9a192a6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_live_video.go 0.00000% 29 Missing ⚠️
server/ai_http.go 0.00000% 25 Missing ⚠️
server/ai_pipeline_status.go 0.00000% 13 Missing ⚠️
server/ai_mediaserver.go 0.00000% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3310         +/-   ##
===================================================
- Coverage   34.04273%   34.00324%   -0.03949%     
===================================================
  Files            141         141                 
  Lines          37027       37070         +43     
===================================================
  Hits           12605       12605                 
- Misses         23703       23746         +43     
  Partials         719         719                 
Files with missing lines Coverage Δ
server/ai_process.go 0.60554% <ø> (ø)
server/auth.go 63.72549% <ø> (ø)
server/ai_mediaserver.go 7.91209% <0.00000%> (-0.17780%) ⬇️
server/ai_pipeline_status.go 0.00000% <0.00000%> (ø)
server/ai_http.go 9.69697% <0.00000%> (-0.38177%) ⬇️
server/ai_live_video.go 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75af747...9a192a6. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_process.go 0.60554% <ø> (ø)
server/auth.go 63.72549% <ø> (ø)
server/ai_mediaserver.go 7.91209% <0.00000%> (-0.17780%) ⬇️
server/ai_pipeline_status.go 0.00000% <0.00000%> (ø)
server/ai_http.go 9.69697% <0.00000%> (-0.38177%) ⬇️
server/ai_live_video.go 0.00000% <0.00000%> (ø)

monitor/pipeline_status.go Outdated Show resolved Hide resolved
server/ai_http.go Outdated Show resolved Hide resolved
monitor/pipeline_status.go Outdated Show resolved Hide resolved
server/ai_http.go Outdated Show resolved Hide resolved
server/ai_live_video.go Show resolved Hide resolved
server/ai_live_video.go Outdated Show resolved Hide resolved
server/ai_live_video.go Outdated Show resolved Hide resolved
server/ai_live_video.go Outdated Show resolved Hide resolved
server/ai_live_video.go Outdated Show resolved Hide resolved
server/ai_live_video.go Outdated Show resolved Hide resolved
@gioelecerati gioelecerati changed the title gateway: events: better parsing and latest last_params gateway: events: better parsing, latest last_params & status endpoint Dec 12, 2024
@gioelecerati gioelecerati marked this pull request as ready for review December 12, 2024 18:44
@victorges victorges changed the title gateway: events: better parsing, latest last_params & status endpoint gateway/events: Create status API with stream/pipeline ID info Dec 12, 2024
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gioelecerati gioelecerati merged commit ae0cb35 into master Dec 12, 2024
18 checks passed
@gioelecerati gioelecerati deleted the gio/events-parsing branch December 12, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants