Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting fixed price per session with initial price 0 #2904

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Oct 31, 2023

Fix the case when the initial price is 0. The price should stick to the session also for this case.

fix #2903

@leszko leszko requested a review from thomshutt October 31, 2023 15:20
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2904 (93a5bd3) into master (b954a1c) will increase coverage by 0.02012%.
The diff coverage is 70.58824%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2904         +/-   ##
===================================================
+ Coverage   56.51257%   56.53269%   +0.02012%     
===================================================
  Files             89          89                 
  Lines          19447       19456          +9     
===================================================
+ Hits           10990       10999          +9     
  Misses          7849        7849                 
  Partials         608         608                 
Files Coverage Δ
core/orchestrator.go 76.87166% <70.58824%> (+0.28167%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b954a1c...93a5bd3. Read the comment docs.

Files Coverage Δ
core/orchestrator.go 76.87166% <70.58824%> (+0.28167%) ⬆️

@leszko leszko merged commit 92ad0e5 into master Nov 2, 2023
18 checks passed
@leszko leszko deleted the rafal/fix-stream-drop branch November 2, 2023 08:43
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-livepeer: Dynamically changing price casues streams drop
2 participants