Replace Ch with ReqCH for ClickHouse integration #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Nov 26, 2024
josevalim
reviewed
Nov 26, 2024
josevalim
reviewed
Nov 26, 2024
added 3 commits
November 27, 2024 15:54
Author
|
@josevalim please take another look. This is linked to livebook-dev/req_ch#6 as well. |
josevalim
reviewed
Nov 27, 2024
josevalim
approved these changes
Nov 27, 2024
jonatanklosko
approved these changes
Nov 28, 2024
Member
jonatanklosko
left a comment
jonatanklosko
left a comment
There was a problem hiding this comment.
We just need to bump the :req_ch requirement and it's ready to ship.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is replacing the
Chpackage with the newly createdReqCHfor the ClickHouse integration.Tests need to be updated, but I want to know if this direction is good first.
I built this on top of #82
Video
req-ch-lb-recording.mp4