fix(sqla_factory): changed default value for __set_foreign_keys__ attr. #632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
__set_foreign_keys__
attribute default value toFalse
Prerequisites for this changing
Thanks to @adhtruong for #624 (comment)
and
My intention would be:
avoiding redundant factory work
Although a foreign key can be used without a relationship, it is most often paired with a relationship. So a particular factory will be doing sort of a double work because creating foreign field data will be overridden by a relationship.
consistency in the field logic with
__set_relationships__
and__set_association_proxy__
(if the last one is added in the future)Closes