feat: add support for Python 3.13 #3850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ci
github-actions
bot
added
area/docs
cofin
commented
Dec 16, 2024
| @@ -96,7 +101,7 @@ opentelemetry = ["opentelemetry-instrumentation-asgi"] | |||
| piccolo = ["piccolo"] | |||
| picologging = ["picologging"] | |||
| prometheus = ["prometheus-client"] | |||
| pydantic = ["pydantic", "email-validator", "pydantic-extra-types"] | |||
| pydantic = ["pydantic", "email-validator", "pydantic-extra-types<=2.9.0; python_version < \"3.9\"", "pydantic-extra-types>=2.9.0; python_version >= \"3.9\""] | |||
There was a problem hiding this comment.
There's an open build issue re: this.
cofin
commented
Dec 16, 2024
| @@ -130,13 +135,14 @@ dev = [ | |||
| "trio", | |||
| "aiosqlite", | |||
| "asyncpg>=0.29.0", | |||
| "psycopg[pool,binary]>=3.1.10,<3.2", | |||
| "psycopg[pool,binary]>=3.1.10,<3.2; python_version < \"3.13\"", | |||
| "psycopg[pool,c]; python_version >= \"3.13\"", | |||
There was a problem hiding this comment.
Package needs to be built for 3.13
cofin
commented
Dec 16, 2024
| from litestar.testing import TestClient | ||
|
|
||
| pytestmark = pytest.mark.xdist_group("sqlalchemy_examples") | ||
|
|
||
|
|
||
| def test_sqlalchemy_declarative_models() -> None: | ||
| from docs.examples.contrib.sqlalchemy.sqlalchemy_declarative_models import app | ||
| async def test_sqlalchemy_declarative_models(tmp_path: Path, monkeypatch: MonkeyPatch) -> None: |
There was a problem hiding this comment.
Without this additional monkey-patching, there were intermittent failures on this job. This is the only way I could make the tests consistently pass on all python versions.
cofin
commented
Dec 16, 2024
| @@ -90,9 +92,9 @@ def cleanup_logging_impl() -> Generator: | |||
| # Don't interfere with PyTest handler config | |||
| if not isinstance(std_handler, (_LiveLoggingNullHandler, LogCaptureHandler)): | |||
| std_root_logger.removeHandler(std_handler) | |||
|
|
|||
| picologging = pytest.importorskip("picologging") | |||
There was a problem hiding this comment.
TIL about this. It will auto-skip if this import fails
cofin
commented
Dec 16, 2024
|
|
||
| exec(f"async def test_fn({reserved_kwarg}: int) -> None: pass") | ||
| handler_with_path_param = decorator("/{" + reserved_kwarg + ":int}")(locals()["test_fn"]) | ||
| local = dict(locals(), **globals()) |
There was a problem hiding this comment.
This also caused some weird issues with the scope of the locals() output. This was the only way I could consistently make sure the call to locals contained the test_fn key
| "anyio>=4 ; python_version >= \"3.9\"", | ||
| "httpx>=0.22", | ||
| "exceptiongroup; python_version < \"3.11\"", | ||
| "eval_type_backport; python_version <= \"3.9\"", |
There was a problem hiding this comment.
Curious: Why do we need this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for Python 3.13.
Note
msgspecbuilt by the Litestar team. This is a drop in replacement until the official pre-built wheels are available.msgspecimplementation, while all other versions prefer the pre-built litestar wheels.psycopg[binary]. If you rely on this for development, you'll need to have the postgres development libraries installedpicologgingdoes not currently support Python 3.13. These tests are skipped automatically.Closes