Fix notice and wrong Regex #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-hai
reviewed
Dec 9, 2024
src/cdn.cls.php
Outdated
| foreach ($matches[1] as $k => $url) { | ||
| if ($url == null) { |
There was a problem hiding this comment.
Should we just use if (!$url) as empty case should be bypassed as well??
There was a problem hiding this comment.
Yes, added the changed
hi-hai
reviewed
Dec 10, 2024
src/cdn.cls.php
Outdated
| @@ -306,8 +306,12 @@ private function _replace_inline_css() | |||
| * @see #685485 | |||
| * @since 3.0 | |||
| */ | |||
| preg_match_all('/url\((?![\'"]?data)[\'"]?([^\)\'"\\\]+)[\'"]?\)/i', $this->content, $matches); | |||
| preg_match_all('/url\((?![\'"]?data)[\'"]?(.*?)[\'"]?\)/i', $this->content, $matches); | |||
There was a problem hiding this comment.
Should we change (.*?) to (.+?)? @timotei-litespeed
There was a problem hiding this comment.
Changed, at least it will filter out empty url :)
hi-hai
reviewed
Dec 10, 2024
src/cdn.cls.php
Outdated
| foreach ($matches[1] as $k => $url) { | ||
| if (!$url) { |
There was a problem hiding this comment.
As its used + now, is this condition redundant? @timotei-litespeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found after looking for this issue: https://wordpress.org/support/topic/php-deprecated-notice-14/