Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config with note for full list of support configs #48

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

drizuid
Copy link
Member

@drizuid drizuid commented Dec 7, 2023

closes #45

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/cops/2.2.1-pkg-4c76ddbe-dev-1cc89119fd5ef98b1115ab7671f08866fb2f8857-pr-48/index.html
https://ci-tests.linuxserver.io/lspipepr/cops/2.2.1-pkg-4c76ddbe-dev-1cc89119fd5ef98b1115ab7671f08866fb2f8857-pr-48/shellcheck-result.xml

Tag Passed
amd64-2.2.1-pkg-4c76ddbe-dev-1cc89119fd5ef98b1115ab7671f08866fb2f8857-pr-48
arm64v8-2.2.1-pkg-4c76ddbe-dev-1cc89119fd5ef98b1115ab7671f08866fb2f8857-pr-48

@mikespub
Copy link
Contributor

mikespub commented Dec 7, 2023

Hi @drizuid since this is a PHP file that will be included, and we want to avoid sending any blank spaces or new lines by mistake, could you please insert the comment after the first 3 lines:

<?php
    if (!isset($config))
        $config = array();

Thanks

root/defaults/config_local.php Outdated Show resolved Hide resolved
@drizuid
Copy link
Member Author

drizuid commented Dec 7, 2023

oops, i should've caught that :D my bad. That is what i get for doing a PR from the phone!
LMK if this looks good now.

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/cops/2.2.1-pkg-4c76ddbe-dev-97b93753c3453432739674de54284c68da346839-pr-48/index.html
https://ci-tests.linuxserver.io/lspipepr/cops/2.2.1-pkg-4c76ddbe-dev-97b93753c3453432739674de54284c68da346839-pr-48/shellcheck-result.xml

Tag Passed
amd64-2.2.1-pkg-4c76ddbe-dev-97b93753c3453432739674de54284c68da346839-pr-48
arm64v8-2.2.1-pkg-4c76ddbe-dev-97b93753c3453432739674de54284c68da346839-pr-48

@drizuid drizuid requested a review from mikespub December 8, 2023 21:23
@mikespub
Copy link
Contributor

mikespub commented Dec 8, 2023

hi @drizuid you're good to go. For some reason Github won't let me approve my own review

@drizuid drizuid requested review from a team and removed request for mikespub December 8, 2023 22:04
@drizuid drizuid merged commit 633a8ee into master Dec 9, 2023
7 checks passed
@drizuid drizuid deleted the config_local branch December 9, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Missing new config options from latest versions of mikespub fork
4 participants