Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust init-permission/run to finish correctly on qnap #252

Closed
wants to merge 3 commits into from

Conversation

klepek
Copy link

@klepek klepek commented Jan 4, 2025

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

init-permission now finishes even when chmod have issue

Benefits of this PR and context:

closes #251

How Has This Been Tested?

package build, package execution and confirmation that it starts

Source / References:

simmilar fix: linuxserver/docker-swag#514

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-bookstack:v24.12-pkg-727bbe4e-dev-72c634af627d80caefdbc6f9f78a13a483fda5d9-pr-252

@developerbuzz
Copy link

I have this issue as well. Do we know if there is a workaround whilst the issue is being resolved?

@thespad
Copy link
Member

thespad commented Jan 8, 2025

We're not going to override base init in downstream images as that way madness lies.

The issue has been reported to QNAP and they've accepted it as a bug but there's no indication is to if/when they will fix it. We've paused any further rebases for nginx-based images for the moment which should prevent any more being affected.

In the meantime any affected images will need to be pinned to versions from before they were rebased to 3.21. We're not going to start applying workarounds because they all involve potentially masking actual errors that could impact other non-QNAP users.

@thespad thespad closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
4 participants