Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting a custom Python version #5

Merged
merged 5 commits into from
Oct 13, 2018
Merged

Support setting a custom Python version #5

merged 5 commits into from
Oct 13, 2018

Conversation

TheLastProject
Copy link
Contributor

No idea of this will work, just an attempt at #3.

@TheAssassin
Copy link
Member

I did conda install python="$CONDA_VERSION", which probably works as well as your script. There is a problem however that neither option allows for installing any Python 3 version but only the latest stable, at least in my tests. We should find a solution for that. If you think this is good enough, though, we can merge this as-is, and look into this later.

@TheLastProject
Copy link
Contributor Author

Requesting Python 3.4 seems to work just fine: https://travis-ci.org/Pext/Pext/jobs/440934890

And my build fails here because SIP needs Python 3.5 at least.

Want me to make another commit to request 3.5 instead?

@TheLastProject
Copy link
Contributor Author

Hmm... do we actually copy the right virtualenv though? I find the code a bit confusing at some points.

@TheLastProject
Copy link
Contributor Author

Okay, tried switching to conda install as well. Maybe you just did it too late into the process? Works fine here.

@TheLastProject
Copy link
Contributor Author

Forgot to post the log: https://travis-ci.org/Pext/Pext/jobs/440974701

@TheAssassin
Copy link
Member

Okay, seems to work. Let's merge it.

@TheAssassin TheAssassin merged commit 0848173 into linuxdeploy:master Oct 13, 2018
@TheAssassin
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants