pkg/compression: Implement system brotli compression #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been tested to decompress and recompress brotli compressed images. So far a brotli compressed OVMF image fails to boot after recompression. It fails at reading the section headers. Signed-off-by: Ian Goegebuer <[email protected]>
Signed-off-by: Ian Goegebuer <[email protected]>
With these settings a recompiled OVMF with linuxboot booted The scratch buffer size needs to be tuned. We don't know what the system tool uses. Maybe we can know when the go library compresses Signed-off-by: Ian Goegebuer <[email protected]>
|
@orangecms this was the diff I was talking about at OSFC |
xaionaro
reviewed
Oct 27, 2023
orangecms
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested to decompress and recompress brotli compressed images. So far a brotli compressed OVMF image fails to boot after recompression. It fails at reading the section headers.