generated from linux-system-roles/template
-
Notifications
You must be signed in to change notification settings - Fork 4
ci: skip most CI checks if title contains citest skip [citest_skip] #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a conditional to multiple GitHub Actions workflows so that most CI jobs are skipped when a pull request title contains the marker string "[citest_skip]". Flow diagram for CI job skipping based on PR title markerflowchart LR
A[Pull_request_created_or_updated] --> B[Read_pull_request_title]
B --> C{Title_contains_citest_skip}
C -- Yes --> D[Evaluate_job_if_condition_not_contains_citest_skip]
D --> E[Job_is_skipped]
C -- No --> F[Run_all_configured_CI_jobs]
F --> G[Report_full_CI_results]
E --> H[Report_reduced_CI_results]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Relying on a magic substring in the PR title (
[citest_skip]) can be brittle and easy to forget; consider using a dedicated label (e.g.ci:skip-heavy) and checkingcontains(github.event.pull_request.labels.*.name, 'ci:skip-heavy')instead for a more robust toggle. - These
ifconditions are duplicated across many workflows; consider extracting this into a reusable workflow or a shared convention (e.g. a single reusableshould-runjob returning an output) to avoid drift if the condition ever needs to change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Relying on a magic substring in the PR title (`[citest_skip]`) can be brittle and easy to forget; consider using a dedicated label (e.g. `ci:skip-heavy`) and checking `contains(github.event.pull_request.labels.*.name, 'ci:skip-heavy')` instead for a more robust toggle.
- These `if` conditions are duplicated across many workflows; consider extracting this into a reusable workflow or a shared convention (e.g. a single reusable `should-run` job returning an output) to avoid drift if the condition ever needs to change.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <[email protected]>
When we submit a PR for a CI update or docs, we do not want to start CI checking for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more roles, this fires off a lot of unnecessary tests, which sometimes causes the linux-system-roles org in github to be throttled. When submitting a PR that can skip ci, use "[citest_skip]" in the PR title. Signed-off-by: Rich Megginson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we submit a PR for a CI update or docs, we do not want to start CI checking
for ansible-lint, qemu, etc. When we are doing CI updates to 30 or more
roles, this fires off a lot of unnecessary tests, which sometimes causes the
linux-system-roles org in github to be throttled.
When submitting a PR that can skip ci, use "[citest_skip]" in the PR title.