Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Jan 13, 2026

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Tests:

  • Add a debug task invoking an invalid Ansible fact to facilitate testing of fact handling behavior.

@richm richm requested a review from spetrosi as a code owner January 13, 2026 17:22
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 13, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a debug task to exercise an invalid Ansible fact variable reference in the role’s main task file.

Flow diagram for updated Ansible role task sequence

flowchart TD
  A[Start role tasks] --> B[Set platform/version specific variables
include_tasks: tasks/set_vars.yml]
  B --> C[Debug0
ansible.builtin.debug msg: bogus {{ ansible_distribution }}]
  C --> D[Ensure required packages are installed
ansible.builtin.package]
  D --> E[Continue remaining role tasks]
Loading

File-Level Changes

Change Details Files
Introduce a debug task that logs a message containing an intentionally invalid Ansible fact variable.
  • Add a new task named 'Debug0' after variable setup to run the Ansible debug module.
  • Configure the debug task to output a static prefix ('bogus') followed by an interpolation of ansible_distribution, which may be undefined/invalid in this context.
tasks/main.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@richm
Copy link
Contributor Author

richm commented Jan 13, 2026

[citest]

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm
Copy link
Contributor Author

richm commented Jan 13, 2026

Tests fail with undefined variable as expected - tests are working

@richm richm closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant