Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Dec 5, 2025

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Update QEMU integration test matrix to target current Fedora releases.

CI:

  • Add Fedora 43 images to QEMU and container-based integration test jobs using ansible-core 2.19.
  • Remove Fedora 41 images from QEMU and container-based integration test jobs.

add qemu tests for Fedora 43, drop Fedora 41

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from spetrosi as a code owner December 5, 2025 20:38
@richm richm self-assigned this Dec 5, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the qemu-kvm GitHub Actions workflow to test against Fedora 43 (both QEMU and container images, including bootc) while dropping Fedora 41 entries and aligning ansible-core versions accordingly.

File-Level Changes

Change Details Files
Extend QEMU test matrix to include Fedora 43 and remove Fedora 41 where previously commented out.
  • Add Fedora 43 QEMU image entry using ansible-core 2.19 to the integration test matrix
  • Remove obsolete/commented Fedora 41 QEMU entry and its associated bug comment
.github/workflows/qemu-kvm-integration-tests.yml
Update container test matrix to replace Fedora 41 with Fedora 43, including bootc variants, and bump ansible-core version for Fedora 43 entries.
  • Remove Fedora 41 container and Fedora 41 bootc entries from the matrix
  • Add Fedora 43 container and Fedora 43 bootc entries using ansible-core 2.19
  • Keep Fedora 42 container and bootc entries unchanged for continuity
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • For the container matrix, Fedora 43 entries use container-ansible-core-2.19 while Fedora 42 still uses 2.17; if the intent is to track ansible-core versions consistently across QEMU and container jobs, it may be worth double-checking that this version skew is intentional.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For the container matrix, Fedora 43 entries use `container-ansible-core-2.19` while Fedora 42 still uses `2.17`; if the intent is to track ansible-core versions consistently across QEMU and container jobs, it may be worth double-checking that this version skew is intentional.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 9a65c30 into main Dec 5, 2025
31 checks passed
@richm richm deleted the ci-qemu-fedora-43 branch December 5, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant