A series of minor fixes #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point, the allowed values for CONFIG_HYPERV went from tristate to boolean. RHEL 9 kernel configs set CONFIG_HYPERV to m but if I use that configuration for 6.17, "make olddefconfig" silently turns that into n. It actually does warn before switching off the setting, but Ansible does not relay that output to the controller, so the warning is lost. I discovered this because the NFSD CI runs on Azure stopped working entirely. After rebooting into the test kernel, the test instances became unreachable via ssh. They could no longer use the Hyper-V network device. I've fixed my config-kdevops, but it would be helpful if bootlinux watched for warnings from "make olddefconfig" so such problems can be identified faster. Signed-off-by: Chuck Lever <[email protected]>
When Claude is checking code cleanliness, it keeps making this tiny clean-up in scripts/generate_cloud_configs.py. Let's merge it to keep America beautiful. Fixes: 29b1922 ("scripts: Add AWS support to generate_cloud_configs.py") Signed-off-by: Chuck Lever <[email protected]>
Fix nits in the Kconfig prompt and help text. Signed-off-by: Chuck Lever <[email protected]>
Clean up. Commit 535726d ("ansible/terraform: integrate Lambda Labs into build system") added CONFIG_TERRAFORM_SSH_CONFIG_PRIVKEY_FILE, but there are already uses of kdevops_config_terraform_ssh_config_privkey_file throughout the tree because scripts/terraform.Makefile already sets it. Thus the kconfig menu setting of CONFIG_TERRAFORM_SSH_CONFIG_PRIVKEY_FILE is completely ignored. Fixes: 535726d ("ansible/terraform: integrate Lambda Labs into build system") Signed-off-by: Chuck Lever <[email protected]>
Clean up: This variable is unique to AWS, so rename it to follow the usual convention. The variable is currently set to a default and never modified, but a subsequent patch will make use of it. Signed-off-by: Chuck Lever <[email protected]>
Daniel Gomez reports:
> Updating and loading repositories:
> Repositories loaded.
> Failed to resolve the transaction:
> No match for argument: isc-dhcp-client
> No match for argument: ifupdown
> You can try to add to command line:
> --skip-unavailable to skip unavailable packages
> virt-builder: error: dnf -y install 'isc-dhcp-client' 'ifupdown': command
> exited with an error
when trying to run Fedora guests on a Debian host.
Checks in the virt_builder.j2 template file that look like this:
{% if distro_debian_based is defined and distro_debian_based %}
assume that the host and guests are running the same OS. Previously,
bringup_guestfs.sh used virtbuilder_os_version for these checks:
OS_VERSION=${CONFIG_VIRT_BUILDER_OS_VERSION}
...
if echo $OS_VERSION | grep -q '^debian'; then
cat <<_EOT >>$cmdfile
append-line /etc/network/interfaces.d/enp1s0:auto enp1s0
append-line /etc/network/interfaces.d/enp1s0:allow-hotplug enp1s0
append-line /etc/network/interfaces.d/enp1s0:iface enp1s0 inet dhcp
firstboot-command dpkg-reconfigure openssh-server
_EOT
Reported-by: Daniel Gomez <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.