-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: [M3-9082, M3-9083] - Dependabot Fixes #11510
base: develop
Are you sure you want to change the base?
Conversation
Coverage Report: ✅ |
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ✅ No vulnerable versions found via
yarn audit
- ✅ Verified
nanoid
is updated to patched version - I believe we can resolve the
path-to-regexp
dependabot alert since the vulnerable version was removed in chore: Fix lastpath-to-regexp
depenabot alert by usingvite preview
instead ofserve
#11015
Looks like cypress failures are unrelated (cc @linode/frontend-sdet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependency versions look good ✅
Storybook local dev server ran stable ✅
Storybook production build worked ✅
Description 📝
└─ postcss@npm:8.4.47
└─ nanoid@npm:3.3.7 (via npm:^3.3.7)
└─ express@npm:4.21.0 (via npm:^4.19.2)
Changes 🔄
express
"vite": "^6.0.7"
(latest at this time) doesn't have3.3.8
Target release date 🗓️
01/28/2025
Verification steps
Run
yarn why nanoid && yarn why path-to-regexp
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅