Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: [M3-9082, M3-9083] - Dependabot Fixes #11510

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Jan 11, 2025

Description 📝

  1. See: https://github.com/linode/manager/security/dependabot/137
    • vite@npm:5.4.11
      └─ postcss@npm:8.4.47
      └─ nanoid@npm:3.3.7 (via npm:^3.3.7)
  2. See: https://github.com/linode/manager/security/dependabot/136
    • @storybook/core@npm:8.3.4
      └─ express@npm:4.21.0 (via npm:^4.19.2)
    • At the end of the day, I'm not sure we can fix this one quite yet. It's also being used by React Router Dom which we're trying to phase out and we're on an old version.

Changes 🔄

  • Bumped "storybook": "^8.4.7" and other deps where they removed express
  • Add resolution "nanoid": "^3.3.8" - "vite": "^6.0.7" (latest at this time) doesn't have 3.3.8

Target release date 🗓️

01/28/2025

Verification steps

Run yarn why nanoid && yarn why path-to-regexp

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai jaalah-akamai requested a review from a team as a code owner January 11, 2025 03:24
@jaalah-akamai jaalah-akamai requested review from bnussman-akamai and harsh-akamai and removed request for a team January 11, 2025 03:24
@jaalah-akamai jaalah-akamai self-assigned this Jan 11, 2025
@jaalah-akamai jaalah-akamai added Dependencies Pull requests that update a dependency file Security Pull requests that address a security vulnerability labels Jan 11, 2025
Copy link

github-actions bot commented Jan 11, 2025

Coverage Report:
Base Coverage: 87.19%
Current Coverage: 87.19%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing473 Passing2 Skipped100m 58s

Details

Failing Tests
SpecTest
linode-config.spec.tsEnd-to-End » Clones a config

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkhalil-akamai hkhalil-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 14, 2025
@hkhalil-akamai
Copy link
Contributor

Looks like cypress failures are unrelated (cc @linode/frontend-sdet)

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency versions look good ✅
Storybook local dev server ran stable ✅
Storybook production build worked ✅

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file Security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants