Add apiToken handling to external-dns-raw template #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merll
reviewed
Feb 9, 2026
| CF_API_TOKEN: "{{ . | b64enc }}" | ||
| {{- end }} | ||
| {{- with .apiSecret }} | ||
| {{- with .apiToken }} |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- with .apiToken }} | |
| {{- with . | get "apiSecret" nil }} |
merll
reviewed
Feb 9, 2026
Contributor
|
Thank you for the report @vaheed and for the PR. Both Of course the template rendering should not fail if either of the values is missing. My suggestions above should fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Fixes a template bug in
external-dns-raw.gotmplwhere the Cloudflare provider references.apiSecret, which is not defined in the Helm values schema. The correct field is.apiToken.Why this is needed
When External-DNS is enabled with Cloudflare,
otomi applyfails during Helm values rendering:executing "stringTemplate" at <.apiSecret>: map has no entry for key "apiSecret"
Related issue
Fixes #2916
🔍 Reviewer Notes
🧹 Checklist