-
Notifications
You must be signed in to change notification settings - Fork 181
feat: BYO Git #2914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CasLubbers
wants to merge
59
commits into
main
Choose a base branch
from
APL-1465
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: BYO Git #2914
+578
−573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rove internal Gitea handling
…checksums for credentials
CasLubbers
commented
Feb 9, 2026
| @@ -1,4 +1,4 @@ | |||
| api: main | |||
| api: APL-1510 | |||
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to change this back
Contributor
|
Comparison of Helm chart templating output: @@ data.giteaPassword @@
# v1/Secret/apl-gitea-operator/apl-gitea-operator-secret
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ spec.template.metadata @@
! + one map entry added:
+ annotations:
+ # Restart pod when git credentials or config changes (important for migration)
+ checksum/git-credentials: cca965a8824cc32153ec28b2a259b856cf7a97fd1c41b1ada29474d4f2bf8bff
+ checksum/git-config: 42222a02649e732ca3ce292c87cbc4bc66622c96cb4588c7c1f517d8c23d3aa9
@@ spec.template.spec.containers.apl-operator @@
! + one map entry added:
+ envFrom:
+ - secretRef:
+ name: apl-sops-secrets
+ - secretRef:
+ name: apl-git-credentials
@@ stringData @@
# v1/Secret/apl-operator/gitea-credentials
! ± type change from map to <nil>
- GIT_USERNAME: otomi-admin
GIT_PASSWORD: giteaAdminPassword
+ <nil>
@@ (root level) @@
# v1/Secret/apl-git-credentials
! + one document added:
+ ---
+ type: Opaque
+ # Source: apl-operator/templates/secrets.yaml
+ apiVersion: v1
+ kind: Secret
+ metadata:
+ name: apl-git-credentials
+ stringData:
+ username: otomi-admin
+ password: gitPasswordForTesting
@@ data.password @@
# v1/Secret/argocd/argocd-repo-creds-gitea
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ data.password @@
# v1/Secret/argocd/argocd-repo-creds-gitea-internal
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ data.password @@
# v1/Secret/gitea-admin-secret
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ data @@
! - one map entry removed:
- GIT_REPO_PUBLIC_URL: "https://gitea.dev.linode-apl.net/otomi/values"
@@ data.GIT_REPO_URL @@
! ± value change
- http://gitea-http.gitea.svc.cluster.local:3000/otomi/values
+ http://gitea-http.gitea.svc.cluster.local:3000/otomi/values.git
@@ data.VERSIONS @@
! ± value change in multiline text (one insert, one deletion)
- {"api":"main","console":"main","consoleLogin":"main","core":"main","specVersion":53,"tasks":"main","tools":"main"}
+ {"api":"APL-1510","console":"APL-1511","consoleLogin":"main","core":"main","specVersion":53,"tasks":"main","tools":"main"}
@@ spec.template.spec.containers.otomi-api.image @@
! ± value change
- docker.io/linode/apl-api:main
+ docker.io/linode/apl-api:APL-1510
@@ data.GIT_EMAIL @@
! ± value change
- bm90QHVzLmVk
+ cGlwZWxpbmVAY2x1c3Rlci5sb2NhbA==
@@ data.GIT_PASSWORD @@
! ± value change
- Z2l0ZWFBZG1pblBhc3N3b3Jk
+ Z2l0UGFzc3dvcmRGb3JUZXN0aW5n
@@ spec.template.spec.containers.otomi-console.image @@
! ± value change
- docker.io/linode/apl-console:main
+ docker.io/linode/apl-console:APL-1511
@@ spec.workspaces.git-credentials.secret.secretName @@
# tekton.dev/v1/PipelineRun/docker-build-demo-java1-v0-0-1
! ± value change
- gitea-credentials
+ apl-git-credentials
@@ apps.gitea @@
! - two map entries removed:
- adminUsername: otomi-admin
- adminPassword: giteaAdminPassword
@@ apps.otomi-api @@
! - one map entry removed:
- git:
- email: [email protected]
- user: someuser
- password: somesecretvalue
@@ otomi @@
! + one map entry added:
+ git:
+ branch: main
+ repoUrl: "http://gitea-http.gitea.svc.cluster.local:3000/otomi/values.git"
+ username: otomi-admin
+ email: [email protected]
+ password: gitPasswordForTesting
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
🔍 Reviewer Notes
🧹 Checklist