Include extra attributes in SubjectAccessReview #13170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes authorization plugins can rely on extra attributes on a user, and these are provided via `X-Remote-Extra-` headers. Currently the Linkerd Viz `tap` API doesn't include these attributes when making the `SubjectAccessReview` request which means the Tap API cannot be used by end-users who's clusters use such authz plugins. This change updates the `tap` controller to parse the `X-Remote-Extra-` headers and include them in the SubjectAccessReview request. Fixed linkerd#13169 Signed-off-by: David Symons <[email protected]>
|
Hey @multimac, just a quick check-in -- we're heads-down to ship Linkerd 2.17 but will be coming back to this as soon as we can. Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes authorization plugins can rely on extra attributes on a user, and these are provided via
X-Remote-Extra-headers. Currently the Linkerd ViztapAPI doesn't include these attributes when making theSubjectAccessReviewrequest which means the Tap API cannot be used by end-users who's clusters use such authz plugins.This change updates the
tapcontroller to parse theX-Remote-Extra-headers and include them in the SubjectAccessReview request.Fixed #13169