Add rate-limiters to ServerPolicy #3305
Open
+521
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeb
force-pushed
the
alpeb/server-policy-rate-limiter
branch
5 times, most recently
from
0536b1f
to
8636f8e
Compare
This adds the local_rate_limit module to the server-policy crate, that `ServerPolicy` uses for its new `local_rate_limit` field, containing three optional rate-limiters: total, identity, overrides (this one is really a vector of limiters, one per configured override). I tried putting that under `Protocol` instead, but the `PartialEq` requirement made it very hard to follow. `Server` OTOH doesn't really require that trait, so I was able to remove it and accommodate the limiters. I made sure to avoid pulling the dashmap dependency in `governor`; I haven't checked yet the necessity of the "jitter" and "quanta" features. This temporarily overrides linkerd2-proxy-api dependency to pick changes from linkerd/linkerd2-proxy-api#388
alpeb
force-pushed
the
alpeb/server-policy-rate-limiter
branch
from
8636f8e
to
b580e65
Compare
olix0r
reviewed
Oct 30, 2024
Closed
alpeb
force-pushed
the
alpeb/server-policy-rate-limiter
branch
from
af63198
to
6d9a4a7
Compare
olix0r
reviewed
Oct 31, 2024
alpeb
force-pushed
the
alpeb/server-policy-rate-limiter
branch
from
adb0cc9
to
15ec396
Compare
alpeb
force-pushed
the
alpeb/server-policy-rate-limiter
branch
from
15ec396
to
3af685b
Compare
olix0r
reviewed
Nov 6, 2024
Comment on lines
+47
to
+48
| impl LocalRateLimit { | ||
| pub fn new_no_overrides( |
There was a problem hiding this comment.
We would typically feature-gate this to assert that it's only used for tests.
Comment on lines
+395
to
+407
| let rsp = svc | ||
| .call( | ||
| ::http::Request::builder() | ||
| .body(hyper::Body::default()) | ||
| .unwrap(), | ||
| ) | ||
| .await | ||
| .expect("serves"); | ||
| let permit = rsp | ||
| .extensions() | ||
| .get::<HttpRoutePermit>() | ||
| .expect("permitted"); | ||
| assert_eq!(permit.labels.route.route, rmeta); |
There was a problem hiding this comment.
Is there some way that we could actually test actually fails when a rate limit is exceeded? E.g. Set of rate limit of 1 and send 2 requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the local_rate_limit module to the server-policy crate, that
ServerPolicyuses for its newlocal_rate_limitfield, containingthree optional rate-limiters: total, identity, overrides (this one is
really a vector of limiters, one per configured override).
I tried putting that under
Protocolinstead, but thePartialEqrequirement made it very hard to follow.
ServerOTOH doesn't reallyrequire that trait, so I was able to remove it and accommodate the
limiters.
I made sure to avoid pulling the dashmap dependency in
governor;Ihaven't checked yet the necessity of the "jitter" and "quanta" features.
This temporarily overrides linkerd2-proxy-api dependency to pick changes
from linkerd/linkerd2-proxy-api#388
Update
The
HttpPolicyServicemiddleware has been expanded to call thelocal_rate_limitmodule above to perform the rate-limit check.