Add support for un compressed files, unit test added. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2018 17:47
Currently in the pathAndCodecforEventLog function in the second case block there is no support for un compressed files, this makes Dr. Elephant look for files with lz4 compression default. This patch adds support for the same.
achyuthsamudrala
changed the title
pralabhkumar
suggested changes
Dec 19, 2018
| @@ -274,6 +282,9 @@ trait SparkUtils { | |||
| // if codec is not available, but we found a file match with appId, use the actual file Path from the first match | |||
| case nocodec if nocodec._1 != None & nocodec._3 == None => (attemptsList(0).getPath(), DEFAULT_COMPRESSION_CODEC) | |||
|
|
|||
| case nocompression if nocompression._1 == None & nocompression._2 == None & nocompression._3 == None | |||
There was a problem hiding this comment.
Please write the coment for this case condition , as have written in another case conditions
| @@ -182,6 +187,7 @@ trait SparkUtils { | |||
| private val IN_PROGRESS = ".inprogress" | |||
| private val DEFAULT_COMPRESSION_CODEC = "lz4" | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Nit : Remove unnecessary lines (apply elsewhere)
| " withlogPath: " + eventLogPath + | ||
| " with codec:" + eventLogCodec) | ||
| " with codec:" + eventLogCodec) |
There was a problem hiding this comment.
Please log also in case eventLogCodec empty (as with no-compression case)
|
@achyuthsamudrala Please add more description in pull request . It will help other reviewers to understand the context better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the pathAndCodecforEventLog function in the second case block there is no support for un compressed files, this makes Dr. Elephant look for files with lz4 compression default. This patch adds support for the same.