bug fix on dot-handled topic names #1989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohitpali Since we are not currently using the PrometheusMetricSampler, would you like to take a look at this one? Thank you! |
|
@CCisGG Looks Good To Me |
CCisGG
approved these changes
Apr 20, 2023
|
Hi @baganokodo2022, looks like there are some checkStyle failures. Could you take a look and address them? Thank you! |
|
oops, circleci webpages don't load for me |
|
I think the build was outdated after 3 months. @baganokodo2022 could you make another commit to trigger the checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen TopicMetrics ccm returned from
PrometheusMetricSamplerare notdot-handled, which causes "missing topic metrics" on topics with dots in their names, in turn, that blocks CC from generating rebalancing proposals.This PR is going to fix the above problem related to
PrometheusMetricSampler. The change should have not effect on already dot-handled topics.Thank you
Xinyu Liu