Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update MSRV to 1.74 #391

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: update MSRV to 1.74 #391

wants to merge 1 commit into from

Conversation

0xdevcollins
Copy link

  • Update Minimum Supported Rust Version (MSRV) to 1.74
  • Modify Cargo.toml to reflect new MSRV
  • Update CI configuration in .github/workflows/ci.yml
  • Update CHANGELOG.md with MSRV change

@0xdevcollins 0xdevcollins mentioned this pull request Oct 13, 2024
Open
@xStrom
Copy link
Member

xStrom commented Oct 17, 2024

We don't need to update the MSRV in order to add lints. The older toolchains will just issue a warning, which is fine.

@PoignardAzur
Copy link

PoignardAzur commented Oct 17, 2024 •
edited
Loading

Well, apparently there's a lot of code triggering these new lints.

I'd recommend doing multiple split PRs as you add the lints one by one and fix the clippy warnings that come up.

DJMcNab
DJMcNab reviewed Oct 17, 2024
View reviewed changes
Cargo.toml
integer_arithmetic = "warn"
match_on_vec_items = "warn"
imprecise_flops = "warn"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, where did this set of lints come from? This isn't as discussed in #369

For reference, the main guidance was recently published in https://linebender.org/wiki/canonical-lints/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xdevcollins @xStrom @PoignardAzur @DJMcNab