-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customizing the MeterIdPrefix
of CircuitBreaker
metrics(#5318)
#5383
Closed
Kyurenpoto
wants to merge
3
commits into
line:main
from
Kyurenpoto:feature/circuit-breaker-meter-id-prefix
Closed
Allow customizing the MeterIdPrefix
of CircuitBreaker
metrics(#5318)
#5383
Kyurenpoto
wants to merge
3
commits into
line:main
from
Kyurenpoto:feature/circuit-breaker-meter-id-prefix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#5318) - Extract `MetricTagBuilder`
Kyurenpoto
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
January 15, 2024 10:50
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5383 +/- ##
============================================
- Coverage 73.94% 73.68% -0.27%
- Complexity 20104 20107 +3
============================================
Files 1730 1741 +11
Lines 74161 74366 +205
Branches 9465 9481 +16
============================================
- Hits 54841 54799 -42
- Misses 14844 15033 +189
- Partials 4476 4534 +58 ☔ View full report in Codecov by Sentry. |
Kyurenpoto
force-pushed
the
feature/circuit-breaker-meter-id-prefix
branch
from
January 16, 2024 07:43
81c34c0
to
02f24a2
Compare
Kyurenpoto
force-pushed
the
feature/circuit-breaker-meter-id-prefix
branch
from
January 16, 2024 08:55
0df1a97
to
d46f1e8
Compare
Kyurenpoto
force-pushed
the
feature/circuit-breaker-meter-id-prefix
branch
2 times, most recently
from
January 25, 2024 01:33
46756e5
to
d46f1e8
Compare
I left my opinion here: #5318 (comment) |
I think we should go with Micrometer Observation as described at #5736. Sorry but let me close this. 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To resolve #5318:
Modifications:
MetricTagBuilder
Result:
We could allow a user to specify the tags that allows a user to choose the MeterIdPrefix of the circuit breaker.