TF-3977 Add disable spam banner in preferences setting #3992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3992. |
dab246
force-pushed
the
enhancement/tf-3977-profile-preferences-be-able-to-disable-spam-banner
branch
from
d35e829 to
3b380a5
Compare
Step to reproduce
Screen.Recording.2025-09-03.at.11.47.59.AM.mov |
Fixed web.mov
Fixed Screen_recording_20250903_131246.webm |
tddang-linagora
previously approved these changes
Sep 3, 2025
hoangdat
reviewed
Sep 8, 2025
| import 'package:tmail_ui_user/main/exceptions/exception_thrower.dart'; | ||
|
|
||
| class LocalSpamReportDataSourceImpl extends SpamReportDataSource { | ||
| final LocalSpamReportManager _localSpamReportManager; | ||
| final PreferencesSettingManager _preferencesSettingManager; |
There was a problem hiding this comment.
We should separate settings keys for easier in conflict. Error in one setting will not impact other settings
dab246
force-pushed
the
enhancement/tf-3977-profile-preferences-be-able-to-disable-spam-banner
branch
from
e63b123 to
f2087e3
Compare
tddang-linagora
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3977
Resolved
Screen.Recording.2025-08-29.at.5.59.18.PM.mov