feat: add --quiet flag to suppress verbose logs in #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: olalekan odukoya <[email protected]>
olamilekan000
force-pushed
the
add-quiet-flag-to-command
branch
from
2721762 to
04b3bdc
Compare
You're welcome! |
nirs
reviewed
Dec 10, 2024
| @@ -33,6 +33,7 @@ func newCopyCommand() *cobra.Command { | |||
| } | |||
|
|
|||
| copyCommand.Flags().BoolP("recursive", "r", false, "copy directories recursively") | |||
| copyCommand.Flags().BoolP("quiet", "q", false, "suppress output logs") | |||
There was a problem hiding this comment.
I would consider making this quiet by default and adding -v --verbose for the verbose output, like the underling command we run and most commands.
There was a problem hiding this comment.
@AkihiroSuda should the PR be updated to go with this flow?
There was a problem hiding this comment.
I believe that's what he meant by "sounds good to me" (SGTM).
alexandear
reviewed
Dec 10, 2024
cmd/limactl/copy.go
Outdated
Comment on lines
131
to
137
| if quiet { | ||
| sshCmd.Stdout = nil | ||
| sshCmd.Stderr = nil | ||
| } else { | ||
| sshCmd.Stdout = cmd.OutOrStdout() | ||
| sshCmd.Stderr = cmd.ErrOrStderr() | ||
| } |
There was a problem hiding this comment.
Can be simplified:
Suggested change
| if quiet { | |
| sshCmd.Stdout = nil | |
| sshCmd.Stderr = nil | |
| } else { | |
| sshCmd.Stdout = cmd.OutOrStdout() | |
| sshCmd.Stderr = cmd.ErrOrStderr() | |
| } | |
| if !quiet { | |
| sshCmd.Stdout = cmd.OutOrStdout() | |
| sshCmd.Stderr = cmd.ErrOrStderr() | |
| } |
The fields are nil by default.
olamilekan000
force-pushed
the
add-quiet-flag-to-command
branch
from
2431aa9 to
c97e496
Compare
Signed-off-by: olalekan odukoya <[email protected]>
Signed-off-by: olalekan odukoya <[email protected]>
olamilekan000
force-pushed
the
add-quiet-flag-to-command
branch
from
c97e496 to
036c68a
Compare
jandubois
reviewed
Dec 10, 2024
| debug, err := cmd.Flags().GetBool("debug") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if debug { | ||
|
|
||
| if debug && !quiet { |
There was a problem hiding this comment.
I don't think the --quiet option should override --debug. It should only apply to the output of the ssh command itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue - #2963 (comment)