allow symfony 4.0 #129
allow symfony 4.0 #129
Conversation
|
@jeanmonod shall i fiix the tests or are even red on master? |
|
i restarted the master branch. this smells like it would not be related to this MR, lets see: https://travis-ci.org/liip/RMT/builds/270377916 |
|
or not. could it have something to do with allowing symfony 4? although there are old version installs, so this should not be the reason. but master is still green... |
|
interesting, there is an open bug with exactly this message: #77. although i don't see how that would be related |
|
So lets fix it :-) |
|
i did a minimal fix that i merged. can you please rebase your branch on master to see if the error goes away? |
|
i also merged #131 - can you please rebase and solve conflicts? |
ElectricMaxxx
force-pushed
the
allow_symfony_4.0
branch
from
e8d6feb to
4edf257
Compare
|
Lets see what happens. |
|
Looks green now :-) |
|
@dbu can you tag a release on then? We should see an effect on: doctrine/phpcr-odm#764 |
This would allow symfony 4.0 for bundles/component requiring yours.
Pleas relase after green and merge.