Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add the phpcs configuration #123

Closed
wants to merge 1 commit into from

Conversation

sseidelmann
Copy link

@sseidelmann sseidelmann commented Jul 13, 2017

Adding the php-cs-fixer with PSR2 styleguide
To let it run:

vendor/bin/php-cs-fixer fix
vendor/bin/php-cs-fixer fix --dry-run

I also fixed two files that are not PSR2 formatted.

It would be nice to insert this into travis:

script:
  - vendor/bin/php-cs-fixer fix --config=.php_cs --verbose --diff --dry-run

@jeanmonod
Copy link
Member

Have you see the builds? There is an issue with the composer dependencies...

@acrobat
Copy link
Contributor

acrobat commented Jul 14, 2017

I'm 👎 on adding this to composer. Imo php-cs-fixer should be installed locally, but this won't enforce the correct use of code style. So maybe it's an option to use a service like styleci.io which will check each pr and report issues with coding style (and provide a patch file)

@sseidelmann
Copy link
Author

@jeanmonod jeah, correct. I will check this later.

@sseidelmann
Copy link
Author

@acrobat Can be closed maybe. See the new PR #125 for the styleci integration

@sseidelmann sseidelmann deleted the add_php_cs_fixer branch July 14, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants