minor: test LaminasDiagnosticsBridgeCheck

liip · Nov 21, 2023 · 20eafa6 · 20eafa6
1 parent e1732e9
commit 20eafa6
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 117 deletions.
diff --git a/composer.json b/composer.json
@@ -27,6 +27,7 @@
     },
     "require-dev": {
         "doctrine/doctrine-bundle": "^2.10",
+        "laminas/laminas-diagnostics": "^1.24",
         "matthiasnoback/symfony-dependency-injection-test": "^4.3|^5.0",
         "phpstan/phpstan": "^1.4",
         "phpunit/phpunit": "^9.5.0",

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,6 +1,3 @@
-includes:
-    - phpstan-baseline.neon
-
 parameters:
     level: 8
     treatPhpDocTypesAsCertain: false

diff --git a/tests/Check/LaminasDiagnosticsBridgeCheckTest.php b/tests/Check/LaminasDiagnosticsBridgeCheckTest.php
@@ -11,7 +11,6 @@
 
 namespace Liip\Monitor\Tests\Check;
 
-use Composer\InstalledVersions;
 use Laminas\Diagnostics\Check\Callback;
 use Laminas\Diagnostics\Result\AbstractResult;
 use Laminas\Diagnostics\Result\Failure;
@@ -30,13 +29,6 @@ final class LaminasDiagnosticsBridgeCheckTest extends TestCase
 {
     use CheckTests;
 
-    public static function setUpBeforeClass(): void
-    {
-        if (!InstalledVersions::isInstalled('laminas/laminas-diagnostics')) {
-            self::markTestSkipped('laminas/laminas-diagnostics is not installed');
-        }
-    }
-
     public static function checkResultProvider(): iterable
     {
         yield [

diff --git a/tests/LiipMonitorBundleTest.php b/tests/LiipMonitorBundleTest.php
@@ -38,10 +38,10 @@ public function services_are_autowired(): void
         /** @var TestService $service */
         $service = self::getContainer()->get(TestService::class);
 
-        $this->assertCount(19, $service->checks);
+        $this->assertCount(21, $service->checks);
         $this->assertCount(3, $service->fooChecks);
         $this->assertCount(1, $service->barChecks);
-        $this->assertCount(1, $service->bazChecks);
+        $this->assertCount(2, $service->bazChecks);
 
         $this->assertSame($service->system, $service->linuxSystem);
     }
@@ -67,13 +67,13 @@ public function execute_list_command(): void
     public function execute_health_command(): void
     {
         $this->executeConsoleCommand('monitor:health')
-            ->assertOutputContains('19 check executed')
+            ->assertOutputContains('21 check executed')
             ->assertOutputContains('OK DBAL Connection "default"')
             ->assertOutputContains('OK Check Service 1: Success')
         ;
 
         $this->executeConsoleCommand('monitor:health -v') // verbose
-            ->assertOutputContains('19 check executed')
+            ->assertOutputContains('21 check executed')
         ;
     }
 
@@ -88,7 +88,7 @@ public function messenger_run_check_suite(): void
         $results = $this->handle(new RunCheckSuite());
 
         $this->assertInstanceOf(ResultSet::class, $results);
-        $this->assertCount(19, $results);
+        $this->assertCount(21, $results);
     }
 
     /**