Symfony 7 compatibillity

[kl3sk]

This may allow Symfony 7 support.

Older version were dropped and older PHP version.

Fell free to comment/annotate 😃

Fixes #630

[alexislefebvre]

Do you know why it fails with PHP 8.2? It may be due to the fact that annotations are not working with PHP 8.2+. 😬

It may work if we convert annotations to attributes in the test entity https://github.com/liip/LiipFunctionalTestBundle/blob/master/tests/App/Entity/User.php

[kl3sk]

This what I was searching for, and agree that is a Doctrine Annotation vs Attributes conflict.

If I'm not wrong, both can be used at the same time.

I'll have a try

[alexislefebvre]

Please hold on, let's check something first: #630 (comment)

[kl3sk]

Ok, so what's next.

Do we close it or I can push my tries with attributes to see what happens ?

[alexislefebvre]

As you want, you can try to migrate to a YAML configuration as in LiipFunctionalTestBundle: https://github.com/liip/LiipTestFixturesBundle/blob/19c9f4281bff0d5e3571de4ba71b66c85ba0b0c4/tests/App/DataFixtures/ORM/user.yml https://github.com/liip/LiipTestFixturesBundle/blob/19c9f4281bff0d5e3571de4ba71b66c85ba0b0c4/tests/App/Resources/config/doctrine/User.orm.yml

Otherwise we'll be able to do it, no problem.

[kl3sk]

LiipFunctionalTestBundle Works fine, this bundle may be at least upgradable to 7.0

The other problème is here I think.

LiipFunctionalTestBundle/tests/App/config.yml

Line 39 in 5658b8a

type: annotation

But how say use attribute for 8.2 and annotation otherwise

I change to attribute to test it.

[alexislefebvre]

But how say use attribute for 8.2 and annotation otherwise

Are annotations still necessary? I'm pretty sure that attributes can be used with Symfony 5.4+.

[alexislefebvre]

If you want to continue to work on this subject, please open another PR where you only drop support of Symfony 4.4 (you'll have to create a branch for that). Once it will be merged, you'll be able to rebase this PR and tests will be run automatically.

[Chris53897]

Please revert "^7.4 || ^8.0" is fine

[Chris53897]

Can you change this, to the following, and see if this fix some errors? On Php 7.4 run.

#[ORM\Entity()]
#[ORM\Table(name: "liip_user")]

[Chris53897]

Can you please add a testrun for php 8.3 as well?

[alexislefebvre]

Feel free to add it in a new PR.

[alexislefebvre]

But how say use attribute for 8.2 and annotation otherwise

Are annotations still necessary? I'm pretty sure that attributes can be used with Symfony 5.4+.

My bad, it requires PHP 8.0+. 😬

[alexislefebvre]

I opened a new PR based on this one:

• chore: allow Symfony 7 #634

[alexislefebvre]

See the release: #630 (comment)