refactor: merge lightning-custom-message into lightning crate#4386
Open
okekefrancis112 wants to merge 2 commits intolightningdevkit:mainfrom
Open
refactor: merge lightning-custom-message into lightning crate#4386okekefrancis112 wants to merge 2 commits intolightningdevkit:mainfrom
okekefrancis112 wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
I've assigned @joostjager as a reviewer! |
okekefrancis112
force-pushed
the
drop_crate
branch
2 times, most recently
from
d0ad0e4 to
a5a2d77
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4386 +/- ##
==========================================
- Coverage 86.03% 86.03% -0.01%
==========================================
Files 156 156
Lines 103002 102990 -12
Branches 103002 102990 -12
==========================================
- Hits 88620 88606 -14
- Misses 11873 11878 +5
+ Partials 2509 2506 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
okekefrancis112
force-pushed
the
drop_crate
branch
from
527de10 to
d062514
Compare
|
🔔 1st Reminder Hey @joostjager! This PR has been waiting for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges the
lightning-custom-messagecrate into the mainlightningcrate. Thelightning-custom-messagecrate was originally separated for MSRV reasons, but both crates now require Rust 1.75, making the separation unnecessary.Backwards Compatibility
The macro remains publicly exported and works identically. Users can now access it via:
Closes: #4198