Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tx_signatures.tlvs field (splicing-specific field in dual funding message) #2991

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

optout21
Copy link
Contributor

Two relatively small changes, in preparation for splicing:

  • New tx_signatures.tlvs field. This field is splicing-specific, and is used for exchanging signature on the previous funding tx, which is a shared input. The spec of this is still non-finalized, just like for the rest of the already-added splicing messages (spec PRs Add funding outpoint sigs to tx_signatures message lightning/bolts#1009 Splice draft (feature 62/63) lightning/bolts#863)

  • Place all Splicing messages -- which are still only placeholders without real functionality -- behind the recently-introduced dual_funding feature flag. Splicing relies on dual funding, and is not usable without dual funding.

Note: command for testing:

RUSTFLAGS="--cfg=dual_funding" cargo test

lightning/src/ln/msgs.rs Outdated Show resolved Hide resolved
lightning/src/ln/msgs.rs Outdated Show resolved Hide resolved
@TheBlueMatt
Copy link
Collaborator

LGTM, modulo @dunxen's comments.

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.66%. Comparing base (1d2a27d) to head (bdbb177).
Report is 17 commits behind head on main.

Files Patch % Lines
lightning/src/ln/msgs.rs 70.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
+ Coverage   89.40%   89.66%   +0.25%     
==========================================
  Files         117      117              
  Lines       96016    98874    +2858     
  Branches    96016    98874    +2858     
==========================================
+ Hits        85842    88653    +2811     
- Misses       7957     8018      +61     
+ Partials     2217     2203      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optout21
Copy link
Contributor Author

Renamed field to more descriptive as suggested.

@optout21 optout21 marked this pull request as ready for review April 16, 2024 06:43
@TheBlueMatt TheBlueMatt merged commit ac9a2c8 into lightningdevkit:main Apr 16, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants