Create fixture to verify snapshot update recency.#64
Open
arik-so wants to merge 1 commit intolightningdevkit:mainfrom
Open
Create fixture to verify snapshot update recency.#64arik-so wants to merge 1 commit intolightningdevkit:mainfrom
arik-so wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
TheBlueMatt
reviewed
Nov 27, 2023
Contributor
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Not sure I understand the point of this - it looks like this is testing the client side code, not the server-side code - does this belong in rust-lightning? What specifically is it testing?
| println!("UPDATE RESULT: {}", update_result); | ||
|
|
||
| // the update result must be a multiple of our snapshot granularity | ||
| assert_eq!(update_result % config::snapshot_generation_interval(), 0); |
Contributor
There was a problem hiding this comment.
Wont this spuriously fail if we ever change the interval?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.