Draft
Conversation
Contributor
Author
|
I need a concept ACK. If this approach to testing is fine, I'll open a PR with the remaining unit tests. |
TheBlueMatt
reviewed
Aug 15, 2023
| futures = "0.3" | ||
|
|
||
| [dev-dependencies] | ||
| lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "e13ff10c63b01d3a9f1618320ce5f17dad2e5b48" } |
Contributor
There was a problem hiding this comment.
Do we actually need anything in upstream or can we stick to 116?
Contributor
Author
There was a problem hiding this comment.
we need the publicly exposed excess_data field in announcements
src/tests/mod.rs
Outdated
| } | ||
| }); | ||
|
|
||
| client.query("TRUNCATE TABLE channel_announcements RESTART IDENTITY CASCADE", &[]).await.unwrap(); |
Contributor
There was a problem hiding this comment.
Lets create a temporary database instead.
Contributor
Author
There was a problem hiding this comment.
they're not really a thing. I can create permanent databases using randomized name suffixes, if that's ok?
Contributor
There was a problem hiding this comment.
Yea, that's what I meant.
arik-so
force-pushed
the
2023/08/first_unit_test
branch
from
ca24a9e to
3f97cb3
Compare
…send incremental updates.
…es-default seen timestamp.
arik-so
force-pushed
the
2023/08/first_unit_test
branch
from
c84a3ad to
67b6d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.